Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/454#discussion_r239092725
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -325,6 +325,12 @@ void
YamlConfiguration::parseRemoteProcessGroupYaml(YAML::Node *rpgNode, core::P
}
}
}
+ } else if (transport_protocol == "RAW") {
+ group->setTransportProtocol(transport_protocol);
+ } else {
+ std::stringstream stream;
+ stream << "Invalid transport protocol " << transport_protocol;
+ throw minifi::Exception(ExceptionType::SITE2SITE_EXCEPTION,
stream.str().c_str());
--- End diff --
I think it's vestigial (existed since the early days of the project )-- no
reason, just no desire to make changes that require unnecessary classes to
change in this PR. If someone said, "it has to be done to approve," I'd go
ahead and do it but a follow on PR like the one you made is perfect.
---
