mcgilman commented on a change in pull request #3442: NIFI-6225 Added
alphabetical sort onto relationship lists for Connection dialog
URL: https://github.com/apache/nifi/pull/3442#discussion_r277335221
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-connection-configuration.js
##########
@@ -102,7 +102,7 @@
initializeSourceProcessor(source).done(function (processor) {
if (!nfCommon.isEmpty(processor.relationships)) {
// populate the available connections
- $.each(processor.relationships, function (i,
relationship) {
+ $.each(processor.relationships.sort(), function (i,
relationship) {
Review comment:
Same as within the connection, I believe the sort is happening server side
[1] and that we should fix the merging to ensure the REST API is consistent
regardless of standalone vs clustered.
[1]
https://github.com/apache/nifi/blob/161e4b57632b2d5454390871980288eb66df2502/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/DtoFactory.java#L2870
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
