mcgilman commented on a change in pull request #3442: NIFI-6225 Added 
alphabetical sort onto relationship lists for Connection dialog
URL: https://github.com/apache/nifi/pull/3442#discussion_r277336891
 
 

 ##########
 File path: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-connection-configuration.js
 ##########
 @@ -102,7 +102,7 @@
                 initializeSourceProcessor(source).done(function (processor) {
                     if (!nfCommon.isEmpty(processor.relationships)) {
                         // populate the available connections
-                        $.each(processor.relationships, function (i, 
relationship) {
+                        $.each(processor.relationships.sort(), function (i, 
relationship) {
 
 Review comment:
   Did you actually encounter the processor relationships not being sorted 
correctly? I'm actually not sure if my previous comment is correct. The DTO 
there should be using a `List` which should preserve the order correctly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to