arpadboda commented on a change in pull request #557: MINIFICPP-850: Add operating system to c2 response URL: https://github.com/apache/nifi-minifi-cpp/pull/557#discussion_r285488292
########## File path: libminifi/include/core/state/nodes/DeviceInformation.h ########## @@ -196,11 +196,9 @@ class Device { /* For an AF_INET* interface address, display the address */ if (family == AF_INET || family == AF_INET6) { - s = getnameinfo(ifa->ifa_addr, - (family == AF_INET) ? sizeof(struct sockaddr_in) : - sizeof(struct sockaddr_in6), - host, NI_MAXHOST, - NULL, 0, NI_NUMERICHOST); + s = getnameinfo(ifa->ifa_addr, (family == AF_INET) ? sizeof(struct sockaddr_in) : sizeof(struct sockaddr_in6), host, NI_MAXHOST, + NULL, + 0, NI_NUMERICHOST); Review comment: This looks a bit weird, is this format intended? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services