arpadboda commented on a change in pull request #557: MINIFICPP-850: Add
operating system to c2 response
URL: https://github.com/apache/nifi-minifi-cpp/pull/557#discussion_r285491775
##########
File path: libminifi/include/core/state/nodes/DeviceInformation.h
##########
@@ -468,6 +470,26 @@ class DeviceInfoNode : public DeviceInformation {
protected:
+ /**
+ * Have found various ways of identifying different operating system variants
+ * so these were either pulled from header files or online.
+ */
+ static inline std::string getOperatingSystem() {
+#ifdef _WIN32
+ return "Windows 32";
+#elif _WIN64
+ return "Windows 64";
Review comment:
This branch is dead in my opinion. I think _WIN32 is always defined when
_WIN64 is, but I might be wrong, I didn't test it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
