phrocker commented on a change in pull request #563: WiP: MINIFICPP-839 - Fix
memleaks
URL: https://github.com/apache/nifi-minifi-cpp/pull/563#discussion_r286035355
##########
File path: libminifi/src/core/Processor.cpp
##########
@@ -176,7 +176,7 @@ void
Processor::removeConnection(std::shared_ptr<Connectable> conn) {
// Connection is destination to the current processor
if (_incomingConnections.find(connection) != _incomingConnections.end()) {
_incomingConnections.erase(connection);
- connection->setDestination(NULL);
Review comment:
hmmm, why this change? I would prefer nullptr here. It's easier to read IMO,
so I think we should either leave this as-is or use nullptr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
