phrocker commented on a change in pull request #563: WiP: MINIFICPP-839 - Fix memleaks URL: https://github.com/apache/nifi-minifi-cpp/pull/563#discussion_r286036223
########## File path: libminifi/include/ResourceClaim.h ########## @@ -112,7 +122,7 @@ class ResourceClaim : public std::enable_shared_from_this<ResourceClaim> { // Full path to the content std::string _contentFullPath; - std::shared_ptr<core::StreamManager<ResourceClaim>> claim_manager_; Review comment: hmmm why are we creating a non-owning reference here? We could potentially lose data in some routes. Seems worrisome. I'll do some testing to validate. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services