bakaid commented on a change in pull request #590: MINIFICPP-621 Nanofi Tailfile example URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r293378291
########## File path: nanofi/include/core/cstructs.h ########## @@ -149,4 +149,15 @@ typedef struct cstream { SOCKET socket_; } cstream; +/**** + * ################################################################## + * STRING OPERATIONS + * ################################################################## + */ + +typedef struct tokens { Review comment: As this struct contains dynamically allocated memory, please provide a free_tokens function for it: it is less error-prone than manually freeing its members every time. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services