bakaid commented on a change in pull request #590: MINIFICPP-621 Nanofi Tailfile example URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r294878612
########## File path: nanofi/ecu/tail_file.c ########## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. +*/ + +#include "api/nanofi.h" +#include "core/string_utils.h" +#include "core/cstructs.h" +#include "core/file_utils.h" +#include <unistd.h> +#include <stdlib.h> +#include <stdio.h> +#include <string.h> +#include <errno.h> +#include <limits.h> +#include <signal.h> +#include <sys/stat.h> + +struct flow_file_records * flowfiles = NULL; +nifi_instance * instance = NULL; +standalone_processor * proc = NULL; +int file_offset = 0; +int stopped = 0; +flow_file_list ff_list; +token_list tks; + +void signal_handler(int signum) { + if (signum == SIGINT || signum == SIGTERM) { + stopped = 1; + } +} + +void transmit_flow_files(nifi_instance * instance) { + flow_file_list_node * head = ff_list.head; + while (head) { + transmit_flowfile(head->ff_record, instance); + head = head->next; + } +} + +void set_offset(int offset) { + file_offset = offset; +} + +int get_offset() { + return file_offset; +} + +void on_trigger_callback(processor_session * ps, processor_context * ctx) { + + char file_path[4096]; + char delimiter[2]; + + if (get_property(ctx, "file_path", file_path, 50) != 0) { + return; + } + + if (get_property(ctx, "delimiter", delimiter, 2) != 0) { + return; + } + + if (strlen(delimiter) == 0) { + printf("Delimiter not specified or it is empty\n"); + return; + } + char delim = '\0'; Review comment: This entire section until checking whether the delimiter is an escape sequence is unnecessary. You have already returned if `strlen(delimiter) == 0`, so `strlen(delimiter) > 0` is true. As `strlen(delimiter) > 0` is true, the first character of the string cannot be a terminating null character, so the `if (delim == '\0')` check is unnecessary as well. The entire section can be substituted with `char delim = delimiter[0];` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
