msharee9 commented on a change in pull request #613: Minificpp 927 Nanofi 
tailfile delimited processor
URL: https://github.com/apache/nifi-minifi-cpp/pull/613#discussion_r304564745
 
 

 ##########
 File path: nanofi/include/core/cstructs.h
 ##########
 @@ -155,9 +155,33 @@ typedef struct cstream {
  * ##################################################################
  */
 
-typedef struct tokens {
-    char ** str_list;
-    uint64_t num_strings;
+typedef struct token_node {
+    char * data;
+    struct token_node * next;
+} token_node;
+
+typedef struct token_list {
 
 Review comment:
   yes, I remember that and I mentioned in that PR that this token_list has 
some additional members that was important for the log_aggregator ecu. If I use 
utlist I will have to have some other structure outside of the list, to keep 
track of the offset in the file. Currently the token_list encapsulates that so 
that token nodes and the offset stay together and it is better to keep it that 
way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to