msharee9 commented on a change in pull request #613: Minificpp 927 Nanofi
tailfile delimited processor
URL: https://github.com/apache/nifi-minifi-cpp/pull/613#discussion_r304568258
##########
File path: nanofi/include/core/cstructs.h
##########
@@ -155,9 +155,33 @@ typedef struct cstream {
* ##################################################################
*/
-typedef struct tokens {
- char ** str_list;
- uint64_t num_strings;
+typedef struct token_node {
+ char * data;
+ struct token_node * next;
+} token_node;
+
+typedef struct token_list {
Review comment:
Yes, I remember that and I mentioned in that PR that if I use utlist, I will
have to use an external structure to keep track of extra variables. Currently
it is encapsulated in token_list staying together with the tokens. Using utlist
would make these variables to be unnecessarily copied into each linked list
node.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
