bakaid commented on a change in pull request #610: MINIFICPP-814 - Fixed ListenHTTP and HTTPClient bugs, created tests f… URL: https://github.com/apache/nifi-minifi-cpp/pull/610#discussion_r305289709
########## File path: extensions/http-curl/client/HTTPClient.cpp ########## @@ -120,8 +120,21 @@ void HTTPClient::forceClose() { } +int HTTPClient::debug_callback(CURL *handle, curl_infotype type, char *data, size_t size, void *userptr) { Review comment: @phrocker That is a good idea, but for maintaining API-compatibility we will have to choose a default value for that flag. I prefer the default value to be the logger mode. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services