bakaid commented on a change in pull request #610: MINIFICPP-814 - Fixed ListenHTTP and HTTPClient bugs, created tests f… URL: https://github.com/apache/nifi-minifi-cpp/pull/610#discussion_r314792013
########## File path: extensions/http-curl/client/HTTPClient.cpp ########## @@ -148,6 +161,52 @@ void HTTPClient::setDisableHostVerification() { curl_easy_setopt(http_session_, CURLOPT_SSL_VERIFYHOST, 0L); } +bool HTTPClient::setSpecificSSLVersion(SSLVersion specific_version) { +#if CURL_AT_LEAST_VERSION(7, 54, 0) + CURLcode ret = CURLE_UNKNOWN_OPTION; + switch (specific_version) { + case SSLVersion::SSLv2: + ret = curl_easy_setopt(http_session_, CURLOPT_SSLVERSION, CURL_SSLVERSION_SSLv2); Review comment: @alopresto @thenatog Since then we talked about this with @phrocker and agreed that the full modifications recommended could be part of 0.7.0. I have already created a follow-up ticket for that: https://issues.apache.org/jira/browse/MINIFICPP-1005 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services