pvillard31 commented on a change in pull request #3610: NIFI-6552 Kudu Put
Operations
URL: https://github.com/apache/nifi/pull/3610#discussion_r318470173
##########
File path:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/PutKudu.java
##########
@@ -169,6 +145,13 @@
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
.build();
+ protected static final PropertyDescriptor IGNORE_NULL = new Builder()
+ .name("Ignore NULL")
+ .description("Ignore NULL on Kudu Put Operation, Update only non-Null
columns if set true")
+ .defaultValue("false")
+ .allowableValues("true", "false")
Review comment:
Not an issue but more for consistency: usually when we have a property using
``.allowableValues`` we also add ``.required(true)``.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
