msharee9 commented on issue #674: Minificpp 1007 - ECU C2 integration.
URL: https://github.com/apache/nifi-minifi-cpp/pull/674#issuecomment-558721337
 
 
   > Next batch of review.
   > 
   > A general observation:
   > The new mass of code uses a huge amount of pthread functions. This means 
that it will very hard to port to Windows, which is, as far as I understand 
something we want to do sooner or later.
   > I would suggest choosing a platform-independent threading library or 
implementing platform-specific threading utilities now, and replace pthread 
functions, or this will become exponentially harder in the future.
   
   Added platform independent thread utils. I was working on it as part of 
MINIFICPP-777. Cherry picked them here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to