msharee9 commented on issue #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#issuecomment-558744961 > @msharee9 Just started the review, I am releasing what I have so far, but I have fundamental questions before continuing the C2 part of the review. > What's the purpose of using CBOR for C2 payload serialization? Is this minifi's C2 CoAP reimplemented? If so, I don't believe that uses CBOR, but a custom binary format, so I don't believe it is compatible. Is this purposely a new serialization format? How does it relate to https://cwiki.apache.org/confluence/display/MINIFI/C2+Design ? We are using CBOR for serde of C2 protocol in nanofi. CBOR has an out of the box api for decoding and encoding information without having to have a schema. It is tedious to write but it is smart enough to pack object types concisely. On the EFM side we have a plan to implement CBOR serde for nanofi heartbeats and operations over CoAP and eventually as we discussed in the last meeting we will march towards having a single CoAP/C2 implementation in C and use it for both NanoFi and MiniFI. I assume the same would be the case with EFM for reusing stuff built for nanofi in minifi. This is not reimplementation of minifi heartbeat. The information sent in nanofi heartbeat is different from minifi. Especially the agent manifest. Please look at the following jira ticket comments section. https://jira.cloudera.com/browse/CEM-503
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
