mattyb149 commented on a change in pull request #3953: NIFI-5901 Added
JSON/JSONB support to PutDatabaseRecord
URL: https://github.com/apache/nifi/pull/3953#discussion_r363445186
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
##########
@@ -252,6 +258,16 @@
.defaultValue("false")
.build();
+ static final PropertyDescriptor MAP_RECORD_TO_JSON = new
PropertyDescriptor.Builder()
+ .name("put-db-record-map-record-to-json")
+ .displayName("Map \"record\" types to JSON")
Review comment:
What if we made this a dropdown with allowable values vs booleans? It
appears that setting the JDBC type to `OTHER` supports both JSON and JSONB (at
least for PostgreSQL), but in the future we may want to support the SQLXML type
for inserting into XML columns and so on. The description of the `JSON` option
should probably explicitly say that the JDBC type is set to `OTHER`, as that
might be helpful information for other databases that do things differently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
