mattyb149 commented on a change in pull request #3953: NIFI-5901 Added JSON/JSONB support to PutDatabaseRecord URL: https://github.com/apache/nifi/pull/3953#discussion_r363445914
########## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java ########## @@ -1042,7 +1072,22 @@ private static String normalizeColumnName(final String colName, final boolean tr return colName == null ? null : (translateColumnNames ? colName.toUpperCase().replace("_", "") : colName); } + private static final ObjectMapper MAPPER = new ObjectMapper(); + + private static String convertMapRecord(Record record) { Review comment: If we use a set of options for what to convert the record to (see my other comment), this method should be named accordingly for converting to a JSON string, as we would need other similar methods for other representations such as XML. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services