msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r379042436
########## File path: libminifi/src/c2/C2Agent.cpp ########## @@ -521,9 +545,9 @@ void C2Agent::handle_describe(const C2ContentResponse &resp) { std::vector<std::string> keys; std::copy_if(unsanitized_keys.begin(), unsanitized_keys.end(), std::back_inserter(keys), [](std::string key) {return key.find("pass") == std::string::npos;}); C2Payload response(Operation::ACKNOWLEDGE, resp.ident, false, true); - response.setLabel("configuration_options"); + response.setLabel("configurationOptions"); Review comment: Agree. The wiki doc is very much out of date and we cannot tell from that if someone might be using it. Will revert the label name. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services