msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement
lightweight C2 heartbeat.
URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r379166388
##########
File path: libminifi/src/c2/C2Agent.cpp
##########
@@ -539,9 +563,9 @@ void C2Agent::handle_describe(const C2ContentResponse
&resp) {
} else if (resp.name == "manifest") {
auto keys = configuration_->getConfiguredKeys();
C2Payload response(Operation::ACKNOWLEDGE, resp.ident, false, true);
- response.setLabel("configuration_options");
+ response.setLabel("configurationOptions");
Review comment:
For jstack "configuration_options" does not appear in the response payload.
The inner payload label matters while serializing json. That is what I found
out while testing DESCRIBE jstack.
On the side note, the DESCRIBE operand should be pstack I believe for a
better name for C++. Looks like jstack was taken from Minifi Java.
Nonetheless, removed that label for jstack response.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
