szaszm commented on a change in pull request #744: MINIFICPP-1171 - Fix "%ll"
format strings in log lines
URL: https://github.com/apache/nifi-minifi-cpp/pull/744#discussion_r387617638
##########
File path: libminifi/src/FlowControlProtocol.cpp
##########
@@ -205,9 +205,9 @@ int FlowControlProtocol::sendRegisterReq() {
return -1;
}
logger_->log_debug("Flow Control Protocol receive MsgType %s",
FlowControlMsgTypeToStr((FlowControlMsgType) hdr.msgType));
- logger_->log_debug("Flow Control Protocol receive Seq Num %ll",
hdr.seqNumber);
+ logger_->log_debug("Flow Control Protocol receive Seq Num %zu",
hdr.seqNumber);
Review comment:
Use `PRIu32` from `<cinttypes>` for `uint32_t`. `zu` is meant to be used for
`size_t`, which is not guaranteed to be the same as `uint32_t`.
The above applies to all changes in this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
