szaszm commented on a change in pull request #744: MINIFICPP-1171 - Fix "%ll"
format strings in log lines
URL: https://github.com/apache/nifi-minifi-cpp/pull/744#discussion_r387649429
##########
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##########
@@ -398,7 +398,7 @@ void ConsumeWindowsEventLog::processEvent(EVT_HANDLE
hEvent) {
if (!EvtRender(NULL, hEvent, EvtRenderEventXml, size, 0, &used,
&propertyCount)) {
if (ERROR_INSUFFICIENT_BUFFER == GetLastError()) {
if (used > maxBufferSize_) {
- logger_->log_error("Dropping event %x because it couldn't be rendered
within %ll bytes.", hEvent, maxBufferSize_);
+ logger_->log_error("Dropping event %x because it couldn't be rendered
within %llu bytes.", hEvent, maxBufferSize_);
Review comment:
Could you change `%x` to `%p` and `%llu` to `%" PRIu64 "`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
