arpadboda commented on issue #746: MINIFICPP-1185 - Remove moodycamel::concurrentqueue from threadpool URL: https://github.com/apache/nifi-minifi-cpp/pull/746#issuecomment-603238186 > Compiled and tested the branch on macOS. > Also rebased MINIFICPP-550 to this branch and tried whether it fixes the C2 task starvation problem that made me find this issue - it does. > @arpadboda What I would really like to see are at least some minimal positive tests for the new `ConcurrentQueue` and `ConditionConcurrentQueue`. We are replacing a known (bad for our purpose, but still tested) implementation with an untested one. There are some minimal ThreadPool tests and indirectly some tests depend on this, but that does not make finding errors easy, so I would really prefer some unit tests here. Absuletly agree, already working on some. Wanted to make sure it works well on all the platforms first (and CI passes).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
