szaszm commented on a change in pull request #746: MINIFICPP-1185 - Remove moodycamel::concurrentqueue from threadpool URL: https://github.com/apache/nifi-minifi-cpp/pull/746#discussion_r397293761
########## File path: libminifi/include/utils/ThreadPool.h ########## @@ -330,20 +331,18 @@ class ThreadPool { // integrated power manager std::shared_ptr<controllers::ThreadManagementService> thread_manager_; // thread queue for the recently deceased threads. - moodycamel::ConcurrentQueue<std::shared_ptr<WorkerThread>> deceased_thread_queue_; + ConcurrentQueue<std::shared_ptr<WorkerThread>> deceased_thread_queue_; // worker queue of worker objects - moodycamel::ConcurrentQueue<Worker<T>> worker_queue_; + ConditionConcurrentQueue<Worker<T>> worker_queue_; std::priority_queue<Worker<T>, std::vector<Worker<T>>, DelayedTaskComparator<T>> delayed_worker_queue_; -// notification for available work - std::condition_variable tasks_available_; +// mutex to protect task status and delayed queue + std::mutex worker_queue_mutex_; Review comment: Thanks and nevermind, I mixed the queues. But there is something that can still be fixed here: whitespaces at the end of line 338 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services