bakaid commented on a change in pull request #758: MINIFICPP-1192 - Add macOS support and in-function offsets to backtrace URL: https://github.com/apache/nifi-minifi-cpp/pull/758#discussion_r410154516
########## File path: libminifi/test/unit/BackTraceTests.cpp ########## @@ -103,9 +103,13 @@ TEST_CASE("BT2", "[TPT2]") { std::vector<BackTrace> traces = pool.getTraces(); for (const auto &trace : traces) { + std::cerr << "Thread name: " << trace.getName() << std::endl; const auto &trace_strings = trace.getTraces(); #ifdef HAS_EXECINFO REQUIRE(trace_strings.size() > 2); + for (const auto& trace_string : trace_strings) { + std::cerr << " - " << trace_string << std::endl; Review comment: Yep, it doesn't take up much stderr output, but helps immensely in verifying the actual stack traces. With different types of symbolic information, the output can be very different, so I used this test to look at different cases on different platforms, and I think it can still be useful for that in the future. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services