[
https://issues.apache.org/jira/browse/OPENNLP-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875854#comment-13875854
]
Joern Kottmann commented on OPENNLP-638:
----------------------------------------
This one I don't understand.
When it is declared as:
getLinker(String entityType, EntityLinkerProperties properties)
It is possible to pass in any other object which extends EntityLinkerProperties
for the properties argument.
> EntityLinker setEntityLinkerProperties should throw Exception and be renamed
> to init(props)
> -------------------------------------------------------------------------------------------
>
> Key: OPENNLP-638
> URL: https://issues.apache.org/jira/browse/OPENNLP-638
> Project: OpenNLP
> Issue Type: Sub-task
> Components: Entity Linker
> Affects Versions: 1.6.0
> Reporter: Mark Giaconia
> Assignee: Mark Giaconia
> Fix For: 1.6.0
>
>
> In order for exceptions to be reported as soon as possible, the
> setEntityLinkerProperties method in the EntityLinker interface should throw
> exceptions and be renamed to init(), so during EntityLinker factory
> reflective instantiation, the error is thrown from the Factory.
> Documentation should reflect that EntityLinker impls should inittialize
> external resources in this method, hence the name change to init(..)
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
