[
https://issues.apache.org/jira/browse/OPENNLP-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875875#comment-13875875
]
Mark Giaconia commented on OPENNLP-638:
---------------------------------------
thanks, I'll add a throws to getLinker.
Also, the generic type arg that extends EntityLinkerProperties was just an
attempt to make it more explicit that the EntityLinkerProperties will be passed
through to the impl's init() method so it can be used to get additional
resources to the impl. I will happily remove if you think it's overkill.
> EntityLinker setEntityLinkerProperties should throw Exception and be renamed
> to init(props)
> -------------------------------------------------------------------------------------------
>
> Key: OPENNLP-638
> URL: https://issues.apache.org/jira/browse/OPENNLP-638
> Project: OpenNLP
> Issue Type: Sub-task
> Components: Entity Linker
> Affects Versions: 1.6.0
> Reporter: Mark Giaconia
> Assignee: Mark Giaconia
> Fix For: 1.6.0
>
>
> In order for exceptions to be reported as soon as possible, the
> setEntityLinkerProperties method in the EntityLinker interface should throw
> exceptions and be renamed to init(), so during EntityLinker factory
> reflective instantiation, the error is thrown from the Factory.
> Documentation should reflect that EntityLinker impls should inittialize
> external resources in this method, hence the name change to init(..)
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
