[
https://issues.apache.org/jira/browse/OPENNLP-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18121301#comment-18121301
]
ASF GitHub Bot commented on OPENNLP-1935:
-----------------------------------------
rzo1 commented on PR #1282:
URL: https://github.com/apache/opennlp/pull/1282#issuecomment-5917668586
@krickert Please rebase onto main. #1302 is in now, so the
`java.lang.String#split` signatures can be added here and the remaining split
cases moved to the `StringUtil` helpers.
While at it: `EventFields.split`, `MascIdentifiers.splitOnXmlWhitespace`,
`MecabDictionary.splitWhitespace` and `HunspellDictionary.split` are the same
"split on runs of separator characters, no empty fields" loop with a different
character test. Please move that into `StringUtil` once instead of four copies.
And again, please push your branches to `apache/opennlp` instead of the
`ai-pipestream` fork. That fork is really bad for collaboration: maintainer
edits don't work on organization-owned forks, so we can't push even a trivial
fix or a rebase. Every small change turns into a patch in a comment and another
round trip. With the branch on `apache/opennlp` I'd have just done this rebase
myself.
> RegEx removal part 10: forbiddenapis guard for java.util.regex in production
> code
> ---------------------------------------------------------------------------------
>
> Key: OPENNLP-1935
> URL: https://issues.apache.org/jira/browse/OPENNLP-1935
> Project: OpenNLP
> Issue Type: Improvement
> Components: Build, Packaging and Test
> Reporter: Kristian Rickert
> Assignee: Kristian Rickert
> Priority: Major
> Fix For: 3.0.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Once this is done, let's put safeguards in place to prevent regex during the
> build except for the spots we have exceptions. It's too easy and standard in
> the language to add them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
