[
https://issues.apache.org/jira/browse/OPENNLP-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18121386#comment-18121386
]
ASF GitHub Bot commented on OPENNLP-1935:
-----------------------------------------
krickert commented on PR #1282:
URL: https://github.com/apache/opennlp/pull/1282#issuecomment-5921408211
Rebased onto main. `StringUtil` now has one non-empty split loop behind
`splitNonEmpty`, `splitOnUnicodeWhitespace` and a new mode-aware
`splitOnWhitespace`; `EventFields`, `MascIdentifiers`, `MecabDictionary` and
`HunspellDictionary` call those instead of their own copies. The `String#split`
signatures were already in the list. The three remaining calls in
`ConlluStream`, `TokenSampleStream` and `DownloadUtil` use the helpers now; the
one in `BasicContextGenerator` goes with #1280.
With that, the guard on main reports the classes still to do: the tokenizer
factories and `TokenizerME`, the parser family (`Parse`,
`AncoraSpanishHeadRules`, `ParserTool`), `NameSample`, `FeatureGeneratorUtil`,
the two normalizers, plus the rest of `ConlluStream`, `DownloadUtil` and
`TokenSampleStream`. Those are the next PRs in the series, so this stays a
draft until they land.
On the fork: understood. This branch is on apache/opennlp from here on.
Continued in https://github.com/apache/opennlp/pull/1348.
> RegEx removal part 10: forbiddenapis guard for java.util.regex in production
> code
> ---------------------------------------------------------------------------------
>
> Key: OPENNLP-1935
> URL: https://issues.apache.org/jira/browse/OPENNLP-1935
> Project: OpenNLP
> Issue Type: Improvement
> Components: Build, Packaging and Test
> Reporter: Kristian Rickert
> Assignee: Kristian Rickert
> Priority: Major
> Fix For: 3.0.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Once this is done, let's put safeguards in place to prevent regex during the
> build except for the spots we have exceptions. It's too easy and standard in
> the language to add them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
