hunhoffe commented on code in PR #5278:
URL: https://github.com/apache/openwhisk/pull/5278#discussion_r928984692
##########
core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/Scheduler.scala:
##########
@@ -289,6 +292,11 @@ object Scheduler {
implicit val logger = new
AkkaLogging(akka.event.Logging.getLogger(actorSystem, this))
+ if (useClusterBootstrap) {
+ AkkaManagement(actorSystem).start()
+ ClusterBootstrap(actorSystem).start()
+ }
Review Comment:
I believe my proposed changes work just fine with seed nodes (in the
single-replica controller and scheduler deployments with Kubernetes, I use a
single seed node and not cluster discovery to save time on component startup).
However, I believe the loadConfigOrThrow proposed above also works with seed
nodes set as environment variables - so both solutions should work well with
ansible and seed nodes.
The only difference for adding the logic pointed out by @ningyougang (e.g.,
code snippet in my last comment) is that it would fail if useCluster flag is
not specified AND seed nodes are not specified. Currently, if neither is
specified, there is no explicit failure, a cluster is just not created
properly... but the controller (and scheduler) still appear to run without
issue in that case. I am not sure if that is intended behavior or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
