hunhoffe commented on code in PR #5278:
URL: https://github.com/apache/openwhisk/pull/5278#discussion_r929000054
##########
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Controller.scala:
##########
@@ -230,6 +233,10 @@ object Controller {
def main(args: Array[String]): Unit = {
implicit val actorSystem = ActorSystem("controller-actor-system")
implicit val logger = new
AkkaLogging(akka.event.Logging.getLogger(actorSystem, this))
+ if (useClusterBootstrap) {
Review Comment:
The controller has an actor system now so if you replicate the controller,
it needs to know how to discover different actors in the
```controller-actor-system```. A reason I assumed this is needed is that
ansible does configure a controller cluster (e.g., specified here:
https://github.com/apache/openwhisk/blob/9bc5e043444d115cec0d79ac47d7002baa522924/ansible/controller.yml#L45).
My goal in this PR was to enable a Kubernetes deployment to function as
similarly to the ansible deployment as possible.
Before the new scheduler, the controller did not have an actor system at all
(other than ```ShardingContainerPoolBalancer``` which has similar logic to what
I added). If you don't support replicating the controller, this is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
