asteed commented on a change in pull request #4122: Protect Package Bindings
from containing circular references
URL:
https://github.com/apache/incubator-openwhisk/pull/4122#discussion_r234430754
##########
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Packages.scala
##########
@@ -243,7 +243,7 @@ trait WhiskPackagesApi extends WhiskCollectionAPI with
ReferencedEntities {
wp.binding map {
// pre-existing entity is a binding, check that new binding is valid
b =>
- checkBinding(b.fullyQualifiedName)
+ checkBinding(binding.fullyQualifiedName)
Review comment:
this was previously checking the _existing_ binding, and not the _incoming_
binding from `content.binding`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
