asteed commented on a change in pull request #4122: Protect Package Bindings
from containing circular references
URL:
https://github.com/apache/incubator-openwhisk/pull/4122#discussion_r235543832
##########
File path:
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Packages.scala
##########
@@ -243,7 +243,7 @@ trait WhiskPackagesApi extends WhiskCollectionAPI with
ReferencedEntities {
wp.binding map {
// pre-existing entity is a binding, check that new binding is valid
b =>
- checkBinding(b.fullyQualifiedName)
+ checkBinding(binding.fullyQualifiedName)
Review comment:
> the error message for fetching a binding missing its references package is
confusing - we should open an issue to also fix that.
>
> currently returns: `The requested resource 'guest/b' does not exist.`
instead of `Binding references a package that does not exist.`
I've created issue https://github.com/apache/incubator-openwhisk/issues/4130
to track this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
