[
https://issues.apache.org/jira/browse/ORC-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016850#comment-16016850
]
ASF GitHub Bot commented on ORC-184:
------------------------------------
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/123#discussion_r117397315
--- Diff: c++/include/orc/Statistics.hh ---
@@ -392,7 +392,14 @@ namespace orc {
virtual uint32_t getNumberOfRowIndexStats(uint32_t columnId) const = 0;
};
-
+ /**
+ * Create ColumnStatistics for writers
+ * @param type of column
+ * @param enableStringComparison whether enable string columns
comparision
+ * @return ColumnStatistics instances
+ */
+ std::unique_ptr<ColumnStatistics> createColumnStatistics(
--- End diff --
Make sense. I will move it to src/Statistics.hh
> [C++] Refactor ColumnStatistics classes for writer
> --------------------------------------------------
>
> Key: ORC-184
> URL: https://issues.apache.org/jira/browse/ORC-184
> Project: ORC
> Issue Type: Sub-task
> Components: C++
> Reporter: Gang Wu
> Assignee: Gang Wu
>
> 1. Add setter functions to ColumnStatistics.
> 2. Refactor ColumnStatistics to reduce duplicate code.
> 3. Add more functions in Int128 and Decimal classes for
> DecimalColumnStatistics.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
