[
https://issues.apache.org/jira/browse/ORC-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016852#comment-16016852
]
ASF GitHub Bot commented on ORC-184:
------------------------------------
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/123#discussion_r117397662
--- Diff: c++/include/orc/Vector.hh ---
@@ -194,6 +194,14 @@ namespace orc {
int32_t scale;
};
+ /**
+ * Compares two decimals
+ * @param decimal1 1st decimal to compare
+ * @param decimal2 2nd decimal to compare
+ * @return true is decimal1 is less than decimal2; otherwise false
+ */
+ bool operator<(Decimal decimal1, Decimal decimal2);
--- End diff --
Decimal and Int128 are in the public APIs as well.
> [C++] Refactor ColumnStatistics classes for writer
> --------------------------------------------------
>
> Key: ORC-184
> URL: https://issues.apache.org/jira/browse/ORC-184
> Project: ORC
> Issue Type: Sub-task
> Components: C++
> Reporter: Gang Wu
> Assignee: Gang Wu
>
> 1. Add setter functions to ColumnStatistics.
> 2. Refactor ColumnStatistics to reduce duplicate code.
> 3. Add more functions in Int128 and Decimal classes for
> DecimalColumnStatistics.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
