[ 
https://issues.apache.org/jira/browse/ORC-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461892#comment-16461892
 ] 

ASF GitHub Bot commented on ORC-341:
------------------------------------

Github user wgtmac commented on a diff in the pull request:

    https://github.com/apache/orc/pull/249#discussion_r185691649
  
    --- Diff: 
java/core/src/java/org/apache/orc/impl/writer/TimestampTreeWriter.java ---
    @@ -28,7 +28,9 @@
     import org.apache.orc.impl.SerializationUtils;
     
     import java.io.IOException;
    -import java.sql.Timestamp;
    +import java.text.DateFormat;
    +import java.text.ParseException;
    +import java.text.SimpleDateFormat;
     import java.util.TimeZone;
     
     public class TimestampTreeWriter extends TreeWriterBase {
    --- End diff --
    
    We should also change writeBatch function below.
    
    The input vector.isUTC may be true while writer.isUseUTCTimestamp() is 
false; vice versa. In this case, we need to convert them to correct writer 
timezone.


> Support time zone as a parameter for Java reader and writer
> -----------------------------------------------------------
>
>                 Key: ORC-341
>                 URL: https://issues.apache.org/jira/browse/ORC-341
>             Project: ORC
>          Issue Type: Improvement
>            Reporter: Jesus Camacho Rodriguez
>            Priority: Major
>
> Currently, time zone is hardcoded as the system default time zone and ORC 
> applies displacement between timestamp values read/written based on time zone.
> This issue aims at adding the option to pass the time zone as a parameter to 
> the reader/writer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to