[ 
https://issues.apache.org/jira/browse/ORC-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464125#comment-16464125
 ] 

ASF GitHub Bot commented on ORC-341:
------------------------------------

Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/249#discussion_r186137062
  
    --- Diff: java/core/src/java/org/apache/orc/impl/writer/WriterImplV2.java 
---
    @@ -373,7 +379,11 @@ private void flushStripe() throws IOException {
           OrcProto.StripeFooter.Builder builder =
               OrcProto.StripeFooter.newBuilder();
           if (writeTimeZone) {
    -        builder.setWriterTimezone(TimeZone.getDefault().getID());
    +        if (useUTCTimeZone) {
    +          builder.setWriterTimezone(TimeZone.getTimeZone("UTC").getID());
    --- End diff --
    
    I'd be tempted to just use setWriterTimezone("UTC"), because we'll already 
fail if UTC is called something else.


> Support time zone as a parameter for Java reader and writer
> -----------------------------------------------------------
>
>                 Key: ORC-341
>                 URL: https://issues.apache.org/jira/browse/ORC-341
>             Project: ORC
>          Issue Type: Improvement
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>            Priority: Major
>
> Currently, time zone is hardcoded as the system default time zone and ORC 
> applies displacement between timestamp values read/written based on time zone.
> This issue aims at adding the option to pass the time zone as a parameter to 
> the reader/writer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to