[
https://issues.apache.org/jira/browse/ORC-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495390#comment-16495390
]
ASF GitHub Bot commented on ORC-343:
------------------------------------
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/273#discussion_r191832950
--- Diff: c++/src/Writer.cc ---
@@ -122,9 +127,17 @@ namespace orc {
}
WriterOptions& WriterOptions::setFileVersion(const FileVersion& version)
{
- // Only Hive_0_11 version is supported currently
- if (version.getMajor() == 0 && version.getMinor() == 11) {
+ // Only Hive_0_11 and Hive_0_12 version are supported currently
+ if (version.getMajor() == 0 && (version.getMinor() == 11 ||
version.getMinor() == 12)) {
--- End diff --
My suggestion is to use this logic to implement
`WriterOptions::getRleVersion()`.
> Enable C++ writer to support RleV2
> ----------------------------------
>
> Key: ORC-343
> URL: https://issues.apache.org/jira/browse/ORC-343
> Project: ORC
> Issue Type: New Feature
> Components: C++
> Reporter: Yurui Zhou
> Priority: Major
>
> Currently only the Java implementation support RleV2 encoder, the C++
> implementation only support RleV2 decoding.
> The issue aims to enable the c++ writer to support RleV2 encoding.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
