[
https://issues.apache.org/jira/browse/ORC-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495758#comment-16495758
]
ASF GitHub Bot commented on ORC-343:
------------------------------------
Github user jamesclampffer commented on a diff in the pull request:
https://github.com/apache/orc/pull/273#discussion_r191933565
--- Diff: c++/src/ColumnWriter.cc ---
@@ -1675,7 +1677,9 @@ namespace orc {
void ListColumnWriter::getColumnEncoding(
std::vector<proto::ColumnEncoding>& encodings) const {
proto::ColumnEncoding encoding;
- encoding.set_kind(proto::ColumnEncoding_Kind_DIRECT);
+ encoding.set_kind(rleVersion == RleVersion_1 ?
--- End diff --
You could clean up the initializer list and avoid long term version
mismatch issues if you add a helper function that maps RleVersion1 to
ColumnEncoding_Kind_DIRECT and RleVersion_2 to ColumnEncoding_Kind_DIRECT_V2
and errors/throws on other values.
> Enable C++ writer to support RleV2
> ----------------------------------
>
> Key: ORC-343
> URL: https://issues.apache.org/jira/browse/ORC-343
> Project: ORC
> Issue Type: New Feature
> Components: C++
> Reporter: Yurui Zhou
> Priority: Major
>
> Currently only the Java implementation support RleV2 encoder, the C++
> implementation only support RleV2 decoding.
> The issue aims to enable the c++ writer to support RleV2 encoding.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
