[
https://issues.apache.org/jira/browse/ORC-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501880#comment-16501880
]
ASF GitHub Bot commented on ORC-372:
------------------------------------
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/277#discussion_r193100003
--- Diff: c++/src/Compression.cc ---
@@ -199,13 +199,16 @@ namespace orc {
uint64_t blockSize,
MemoryPool& pool);
+ ~ZlibCompressionStream() { end(); }
--- End diff --
You need an override on this or the mac complains.
> Enable valgrind for C++ travis-ci tests
> ---------------------------------------
>
> Key: ORC-372
> URL: https://issues.apache.org/jira/browse/ORC-372
> Project: ORC
> Issue Type: Improvement
> Reporter: Deepak Majeti
> Assignee: Deepak Majeti
> Priority: Major
>
> It will be useful to run valgrind as part of the travis-ci tests
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
