[
https://issues.apache.org/jira/browse/ORC-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501916#comment-16501916
]
ASF GitHub Bot commented on ORC-372:
------------------------------------
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/277#discussion_r193106126
--- Diff: c++/test/CMakeLists.txt ---
@@ -64,7 +64,12 @@ target_link_libraries (create-test-files
protobuf
)
-add_test (NAME orc-test COMMAND orc-test)
+if (TEST_VALGRIND_MEMCHECK)
+ add_test (orc-test
--- End diff --
You have trailing spaces here.
> Enable valgrind for C++ travis-ci tests
> ---------------------------------------
>
> Key: ORC-372
> URL: https://issues.apache.org/jira/browse/ORC-372
> Project: ORC
> Issue Type: Improvement
> Reporter: Deepak Majeti
> Assignee: Deepak Majeti
> Priority: Major
>
> It will be useful to run valgrind as part of the travis-ci tests
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
