[
https://issues.apache.org/jira/browse/ORC-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701183#comment-16701183
]
ASF GitHub Bot commented on ORC-434:
------------------------------------
omalley commented on a change in pull request #337: ORC-434: Fix incorrect
documentation for Date/Timestamp ColumnStatistics
URL: https://github.com/apache/orc/pull/337#discussion_r236893631
##########
File path: site/specification/ORCv0.md
##########
@@ -308,7 +308,7 @@ message DateStatistics {
```
Timestamp columns record the minimum and maximum values as the number of
-milliseconds since the epoch (1/1/2015).
+milliseconds since the UNIX epoch (1/1/1970 00:00:00 in UTC).
Review comment:
This is wrong. Timestamps are millis since 1/1/2015, until we added
minimumUtc and maximumUtc in ORC-135 f2b8b799c .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix incorrect documentation for Date/Timestamp ColumnStatistics
> ---------------------------------------------------------------
>
> Key: ORC-434
> URL: https://issues.apache.org/jira/browse/ORC-434
> Project: ORC
> Issue Type: Bug
> Components: documentation
> Reporter: Gang Wu
> Assignee: Gang Wu
> Priority: Major
>
> In the documentation of ORC specification, the following two statements are
> wrong:
> * Date columns record the minimum and maximum values as the number of days
> since the epoch (1/1/2015).
> * Timestamp columns record the minimum and maximum values as the number of
> milliseconds since the epoch (1/1/2015).
> The correct epoch is UNIX time epoch which is January 1, 1970 in UTC.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
