[ https://issues.apache.org/jira/browse/ORC-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702106#comment-16702106 ]
ASF GitHub Bot commented on ORC-434: ------------------------------------ omalley commented on issue #337: ORC-434: Fix incorrect documentation for Date/Timestamp ColumnStatistics URL: https://github.com/apache/orc/pull/337#issuecomment-442510469 Ok, I committed this. I misremembered exactly what we did in ORC-135. It was always from the UNIX epoch, but we weren't adjusting the values into UTC before ORC-135. Please look at the text I put in to see if it is clear. ORCv2 won't include the pre-ORC-135, so I removed that part. Now that I think about it, ORCv0 probably should include the ORC-135 discussion, because we can still write the v0 format. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix incorrect documentation for Date/Timestamp ColumnStatistics > --------------------------------------------------------------- > > Key: ORC-434 > URL: https://issues.apache.org/jira/browse/ORC-434 > Project: ORC > Issue Type: Bug > Components: documentation > Reporter: Gang Wu > Assignee: Gang Wu > Priority: Major > > In the documentation of ORC specification, the following two statements are > wrong: > * Date columns record the minimum and maximum values as the number of days > since the epoch (1/1/2015). > * Timestamp columns record the minimum and maximum values as the number of > milliseconds since the epoch (1/1/2015). > The correct epoch is UNIX time epoch which is January 1, 1970 in UTC. -- This message was sent by Atlassian JIRA (v7.6.3#76005)