stiga-huang commented on code in PR #1158:
URL: https://github.com/apache/orc/pull/1158#discussion_r903327104
##########
c++/src/ByteRLE.cc:
##########
@@ -433,6 +441,13 @@ namespace orc {
void ByteRleDecoderImpl::next(char* data, uint64_t numValues,
char* notNull) {
+ AutoStopwatch meassure(&metrics.ByteDecodingLatencyUs,
Review Comment:
This is not the pure decoding time since it contains reading buffers from
the input stream. So it's actually ioTime + decompressionTime + decodingTime. I
think we should either fix it or document it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
