stiga-huang commented on code in PR #1158:
URL: https://github.com/apache/orc/pull/1158#discussion_r903329410
##########
c++/include/orc/Reader.hh:
##########
@@ -32,13 +32,34 @@
#include <set>
#include <string>
#include <vector>
+#include <atomic>
namespace orc {
// classes that hold data members so we can maintain binary compatibility
struct ReaderOptionsPrivate;
struct RowReaderOptionsPrivate;
+ /**
+ * Expose the reader metrics including the latency and
+ * number of calls of the decompression/decoding/IO modules.
Review Comment:
Please document the relation of the latency counters. IIUC,
ReaderInclusiveLatencyUs contains the time of decoding latency. Decoding
latency contains the time of decompression latency which finally contains the
time of IO blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
