hoffermei opened a new pull request, #1641:
URL: https://github.com/apache/orc/pull/1641
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g.,
`ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of
describing the problem.
3. Make PR title and description complete because these will be the
permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce
the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
fix for #1640
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
do reset BooleanRleEncoderImpl::current and
BooleanRleEncoderImpl::bitsRemained when suppress
### Why are the changes needed?
As #1640 suppress no null present stream leaves dirty data of
BooleanRleEncoderImpl::current and BooleanRleEncoderImpl::bitsRemained, which
will be flush to next stripe's present stream if it has some null values.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
I hava add a test testSuppressPresentStreamInPreStripe, which will construct
a orc file with two stripe, the first stripe has no null value and seconds
stripe has some null values. The constructed orc file writer have some dirty
data in BooleanRleEncoderImpl for present stream. In the test I have add check
for read ok and read result is same as write.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
