wgtmac commented on code in PR #1641:
URL: https://github.com/apache/orc/pull/1641#discussion_r1368149566
##########
c++/test/TestWriter.cc:
##########
@@ -2113,6 +2113,84 @@ namespace orc {
EXPECT_FALSE(rowReader->next(*batch));
}
+ // first stripe has no null value adn second stripe has null value
+ // make sure no dirty data leave by present in first stripe
+ TEST_P(WriterTest, testSuppressPresentStreamInPreStripe) {
+ MemoryOutputStream memStream(DEFAULT_MEM_STREAM_SIZE);
+ MemoryPool* pool = getDefaultPool();
+
+ // [1-998000): notNll, value equal index
+ // [998000-999000): null
+ // [999000-1000000]: notNoll, value equal index
Review Comment:
```suggestion
// [999000-1000000]: notNoll, value is equal to index
```
##########
c++/test/TestWriter.cc:
##########
@@ -2113,6 +2113,84 @@ namespace orc {
EXPECT_FALSE(rowReader->next(*batch));
}
+ // first stripe has no null value adn second stripe has null value
+ // make sure no dirty data leave by present in first stripe
Review Comment:
```suggestion
// first stripe has no null value and second stripe has null value.
// make sure stripes do not have dirty data in the present streams.
```
##########
c++/test/TestWriter.cc:
##########
@@ -2113,6 +2113,84 @@ namespace orc {
EXPECT_FALSE(rowReader->next(*batch));
}
+ // first stripe has no null value adn second stripe has null value
+ // make sure no dirty data leave by present in first stripe
+ TEST_P(WriterTest, testSuppressPresentStreamInPreStripe) {
+ MemoryOutputStream memStream(DEFAULT_MEM_STREAM_SIZE);
+ MemoryPool* pool = getDefaultPool();
+
+ // [1-998000): notNll, value equal index
Review Comment:
```suggestion
// [1-998000): notNull, value is equal to index
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
