wgtmac opened a new pull request, #2108:
URL: https://github.com/apache/orc/pull/2108

   ### What changes were proposed in this pull request?
   
   The change to add support for exporting CMake config and target has 
introduced some minor issues when the ORC C++ library is used inside a larger 
CMake project. Mainly there are three issues:
   
   - We should prepend (not append) our CMake modules so we always use our own 
modules when there are naming conflict.
   - Do not use CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR because they are tied to 
the root project and it is no longer ORC project when we are inside another 
project.
   - Add orc_ prefix to our CMake functions to avoid potential conflict.
   
   See: https://github.com/apache/arrow/pull/45226
   
   ### Why are the changes needed?
   
   We had a problem with upgrading Apache ORC to 2.1.0 in the Apache Arrow. 
See: https://github.com/apache/arrow/pull/45226
   
   ### How was this patch tested?
   
   - Pass all CIs.
   - Manually integrated it with Apache Arrow. 
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to