kou commented on code in PR #2108:
URL: https://github.com/apache/orc/pull/2108#discussion_r1912904056
##########
c++/src/CMakeLists.txt:
##########
@@ -218,8 +218,8 @@ target_include_directories (orc
INTERFACE
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
PUBLIC
- $<BUILD_INTERFACE:${CMAKE_SOURCE_DIR}/c++/include>
- $<BUILD_INTERFACE:${CMAKE_BINARY_DIR}/c++/include>
+ $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/c++/include>
+ $<BUILD_INTERFACE:${PROJECT_BINARY_DIR}/c++/include>
Review Comment:
This is not related to this PR but... In general, build directory -> source
directory order is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
