dongjoon-hyun commented on code in PR #2249:
URL: https://github.com/apache/orc/pull/2249#discussion_r2136861282


##########
README.md:
##########
@@ -115,3 +115,43 @@ Cmake option BUILD_ENABLE_AVX512 can be set to "ON" or 
(default value)"OFF" at t
 Environment variable ORC_USER_SIMD_LEVEL can be set to "AVX512" or (default 
value)"NONE" at the run time. At run time, it defines the SIMD level to 
dispatch the code which can apply SIMD optimization.
 
 Note that if ORC_USER_SIMD_LEVEL is set to "NONE" at run time, AVX512 will not 
take effect at run time even if BUILD_ENABLE_AVX512 is set to "ON" at compile 
time.
+
+### Building with Meson
+
+While CMake is the official build system for orc, there is unofficial support 
for using Meson to build select parts of the project. To build a debug version 
of the library and test it using Meson, from the project root you can run:
+
+```shell
+meson setup builddir

Review Comment:
   1. To be consistent with the existing build directory of this `README.md`, 
please use `build` instead of `builddir`.
   2. Otherwise, we need to add `builddir` to `.gitignore` additionally. So, we 
prefer (1).
   ```
   $ git status
   On branch add-meson
   Untracked files:
     (use "git add <file>..." to include in what will be committed)
        builddir/
   ```
   3. We need to update `build_and_test.yml` file together with `build`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to